Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate dolt remote to SQL #7880

Merged
merged 5 commits into from
May 20, 2024
Merged

Migrate dolt remote to SQL #7880

merged 5 commits into from
May 20, 2024

Conversation

macneale4
Copy link
Contributor

Fixes: #7622

@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
70a5c2f ok 5937457
version total_tests
70a5c2f 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
71e7e8c ok 5937457
version total_tests
71e7e8c 5937457
correctness_percentage
100.0

@macneale4 macneale4 force-pushed the macneale4/sql-migration-remote branch from 3d4821e to 9b1048a Compare May 19, 2024 14:08
@macneale4 macneale4 force-pushed the macneale4/sql-migration-remote branch from 9b1048a to 5273450 Compare May 19, 2024 14:11
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
5273450 ok 5937457
version total_tests
5273450 5937457
correctness_percentage
100.0

@macneale4 macneale4 requested a review from nicktobey May 19, 2024 14:49
@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
86b7c6a ok 5937457
version total_tests
86b7c6a 5937457
correctness_percentage
100.0

nicktobey
nicktobey approved these changes May 20, 2024
View reviewed changes
go/cmd/dolt/commands/remote.go Outdated Show resolved Hide resolved
go/cmd/dolt/commands/remote.go Outdated Show resolved Hide resolved
@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
cd17368 ok 5937457
version total_tests
cd17368 5937457
correctness_percentage
100.0

@macneale4 macneale4 merged commit b6b8f8b into main May 20, 2024
20 checks passed
@macneale4 macneale4 deleted the macneale4/sql-migration-remote branch May 20, 2024 20:18
@BrewTestBot BrewTestBot mentioned this pull request May 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicktobey nicktobey nicktobey approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate dolt remote to SQL
3 participants
@macneale4 @coffeegoddd @nicktobey