Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid NewEmptyIndex when table does not exist #7879

Merged
merged 4 commits into from
May 20, 2024
Merged

avoid NewEmptyIndex when table does not exist #7879

merged 4 commits into from
May 20, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented May 17, 2024

It would be better to have NewEmptyIndex not write to chunkstore, but I'm not sure if it's possible right now.
Workaround is to just avoid calling it altogether in this particular case.

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c87be66 ok 5937457
version total_tests
c87be66 5937457
correctness_percentage
100.0

Copy link
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jycor jycor changed the title avoid NewEmptyIndex when table does not exist avoid NewEmptyIndex when table does not exist May 20, 2024
@jycor jycor merged commit 68db779 into main May 20, 2024
20 of 21 checks passed
@jycor jycor deleted the james/stats branch May 20, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants