Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sql patch statement generation APIs to the sqlfmt package #7878

Merged
merged 3 commits into from
May 22, 2024

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented May 17, 2024

We have a few different APIs scattered around for generating SQL patch statements. I needed to make some functions from dolt_patch_table_function.go public to generate DDL statements for binlog support, so I moved them into the sqlfmt package and cleaned up some package import cycles along the way.

@fulghum fulghum requested a review from zachmu May 17, 2024 21:58
@coffeegoddd

This comment was marked as duplicate.

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000
version result total
fafed52 ok 5937457
version total_tests
fafed52 5937457
correctness_percentage
100.0

@fulghum fulghum merged commit 67a6c83 into main May 22, 2024
20 checks passed
@fulghum fulghum deleted the fulghum/binlog-dev-2 branch May 22, 2024 18:52
@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000
version result total
2486f91 ok 5937457
version total_tests
2486f91 5937457
correctness_percentage
100.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants