Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various test utils and small fixes #7872

Merged
merged 3 commits into from
May 22, 2024
Merged

Various test utils and small fixes #7872

merged 3 commits into from
May 22, 2024

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented May 17, 2024

As part of the work for binlog source support (on fulghum/binlog_prototype branch), these are various smaller changes to tidy up docs, packaging, small bug fixes, and add new test utils that I've pulled out into this PR to review separately.

Notable changes:

@coffeegoddd

This comment was marked as duplicate.

@coffeegoddd

This comment was marked as duplicate.

@coffeegoddd

This comment was marked as duplicate.

@coffeegoddd

This comment was marked as duplicate.

@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000
version result total
5ff76cd ok 5937457
version total_tests
5ff76cd 5937457
correctness_percentage
100.0

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachmu zachmu merged commit 688c02e into main May 22, 2024
20 checks passed
@fulghum fulghum deleted the fulghum/binlog-dev-1 branch May 22, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants