Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt: refector tag list pagination support #4353

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

njucjc
Copy link

@njucjc njucjc commented May 15, 2024

Not need to list all tag in paging.

@github-actions github-actions bot added area/storage area/config Related to registry config area/proxy Related to registry as a pull-through cache area/api labels May 15, 2024
@milosgajdos
Copy link
Member

Can you please describe in detail what is it you are trying to accomplish with this PR.

@njucjc
Copy link
Author

njucjc commented May 15, 2024

Can you please describe in detail what is it you are trying to accomplish with this PR.

@milosgajdos #4315 (reply in thread)

According to this discussion, it's not necessary to load all tags to memory in pagination case.

@milosgajdos
Copy link
Member

yeah that's not been released yet

@njucjc
Copy link
Author

njucjc commented May 15, 2024

yeah that's not been released yet

Yeah, maybe we shall wait until a new stable release is cut

@njucjc
Copy link
Author

njucjc commented May 21, 2024

yeah that's not been released yet

@milosgajdos
This PR can be executed in two stages:

  1. to optimize the tag list pagination. I propose transitioning from loading all tags simultaneously into memory to a mechanism that leverages the last parameter for pagination. This method will start querying from the last fetched item, reducing memory load. This optimization will yield benefits when pagination parameters are specified. I think this stage could merge to upstream firstly.
  2. after the release of a new version of the distribution-spec, we plan to expand the maximum page size allowed for pagination. This enhancement aims to prepare for future scalability needs.

I will submit another PR to complete the first stage.

Signed-off-by: njucjc <njucjc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api area/config Related to registry config area/proxy Related to registry as a pull-through cache area/storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants