Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: Clean up sidebar modals #26999

Merged
merged 3 commits into from
May 21, 2024
Merged

DEV: Clean up sidebar modals #26999

merged 3 commits into from
May 21, 2024

Conversation

CvX
Copy link
Contributor

@CvX CvX commented May 13, 2024 •
edited

  1. async/await
  2. TrackedSet
  3. don't rely on ember array methods
  4. list used props
  5. move stuff out of constructors
  6. don't use ember's Input component
  7. convert a function to a method (to avoid passing in a class prop)
  8. add missing @tracked
  9. remove tracking from props that don't need it (not used in templates)

CvX added 3 commits May 13, 2024 11:17
@CvX
DEV: Clean up sidebar modals
e71c409 
1. async/await
2. TrackedSet
3. don't rely on ember array methods
4. list used props
5. move stuff out of constructors
6. don't use ember's Input component
7. convert a function to a class method (to avoid passing in a class prop)
8. add missing `@tracked`
9. remove tracking from props that don't need it (not used in templates)
10.
@CvX
Merge branch 'main' into 0-a-clean-sidebar-modals
1368e0f
@CvX
fix the tags modal
b587bb0
@CvX CvX marked this pull request as ready for review May 14, 2024 10:20
@CvX CvX merged commit eb2df2b into main May 21, 2024
16 checks passed
@CvX CvX deleted the 0-a-clean-sidebar-modals branch May 21, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaylorhq davidtaylorhq davidtaylorhq approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@CvX @davidtaylorhq