Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reload button for custom events #2232

Closed

Conversation

suppayami
Copy link
Contributor

  • Update event cache
  • Reload event buttons on Timeline Right bar
  • Rebuild all EventBlock in Timeline

@Jowan-Spooner
Copy link
Collaborator

Hey, thanks for the PR.
The implementation looks good, but I don't really see the point of the feature. The same can be achieved by switching to a different timeline or into text mode and back. This is really only needed when editing a custom events script, in which case you are not in the settings, so having the button in the settings seems like 2 more steps to me. MAYBE a reload button at the top of the visual timeline editor would make sense, but then again, I don't think it would add much.

Sorry to discuss this after you've already implemented it, but for things like this I'd suggest making a feature request first, so we can discuss it. In this case, we can discuss it here though, idc.

@suppayami
Copy link
Contributor Author

@Jowan-Spooner Hi, it was my bad not discuss before making PR, I got into problem of event block not reloaded and found a thread on Discord discussed about reload button.

It seems that with latest code in main the event block properly reloads without restart the editor now. I think this can be closed.

@Jowan-Spooner
Copy link
Collaborator

Alright, thanks! Glad it works now ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants