Remove the need to pass an account to envForRemoteOperation #18627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
We don't want to accidentally reference it Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
tidy-dev
previously approved these changes
May 22, 2024
tidy-dev
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: #18586
Description
Follow-up to #18626.
This is mostly a refactor PR that removes the previously unused
accountparameter fromenvForRemoteOperation. This in turn lets us remove the usage ofgetGenericHostnamefromAppStoreby means of changing thewithAuthenticatingUserto just ensure an up-to-dateGitHubRepositoryassociation.Functionally we don't expect any changes due to this PR but noteworthy is that we've ensured that all uses of
withRefreshedGitHubRepository(previouslywithAuthenticatingUser) intentionally shadow the previous repository variable so that we don't accidentally use it. We found a few cases where this was happening but believe it should only have affected proxy resolution and if anything it would be more accurate now so we're not worried about it.Screenshots
Release notes
Notes: