-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add appearance setting to adjust tab size #17469
Conversation
We just talked about this and decided to follow GitHub.com approach (check https://github.com/settings/appearance), so basically what you just did 😄 The main difference is that the default tab size, as with GitHub.com, will be 8. |
D'oh! I'm so used to a width of 4 that I made that the default without even thinking lmao. Easy fix though! |
8e4b718
to
38bdae1
Compare
Now that #17428 has been merged, I've rebased the repo so it can be tested as-is |
I was just about to suggest adding this feature in to match the website settings. Looking forward to using it! |
0c40a0e
to
1bb4dd9
Compare
@sergiou87 Checking up on if there's anything that needs to be done on my end for this PR; it's been a bit since I last touched it, so now everything is rebased against the current dev. |
@Repiteo sorry, we just talked about it today: we agreed that based on the website's settings, it should be a dropdown instead of a textbox: Also you should add a header just like Thank you for your patience 🙇♂️ |
1bb4dd9
to
118c753
Compare
118c753
to
0dc3cc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for those changes!! Looks and works great 🙇♂️
Closes #15561
Description
Previously, tab characters on GitHub Desktop were always rendered at 8 spaces in width, in constrast to the site offering several options for tab size. This PR serves to add that functionality; though, instead of a list of integers, it instead utilizes a TextBox. Any input will be converted to a number and, if valid, clamped between 1 and 16. Much like themes, this setting will update the appearance in realtime
Though not strictly required, I'd highly recommend this be added either alongside or sometime after Render tab characters properly in diffs #17428. The current tab display is broken, with values under 5 being erroneously truncated for the first character in a line. As such, the ability to access lower values is likely to display erroneously as-is, and this kind of update would be far better suited for an environment where the functionality is working as expectedMerged!Screenshots
Example taken using #17428
23-09-30.12-42-53.GitHubDesktop-dev.mp4
Release notes
Notes: [New] Allow customizing tab character width in spaces