[bk] add nightly oss pipeline #21956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @benpankow and the rest of your teammates on |
benpankow
commented
May 17, 2024
| @@ -45,18 +45,18 @@ def build_library_packages_steps() -> List[BuildkiteStep]: | |||
| ], | |||
| ] | |||
|
|
|||
| return _build_steps_from_package_specs( | |||
| return build_steps_from_package_specs( | |||
There was a problem hiding this comment.
to be used in stacked PR to build steps for dagster-dbt for nightly pipeline
benpankow
added a commit
that referenced
this pull request
May 21, 2024
…t code on snowflake & bigquery (#21952) ## Summary Adds Snowflake & BQ tests of new row-count functionality and fixes bug with `Table` return on certain warehouses (incl Snowflake). Added to the new OSS nightly pipeline introduced in #21956 to avoid racking up unnecessary spend. We do already run some tests on these warehouses as part of normal builds for their respective integrations, so maybe it's fine to do the same here - open to either. ## Test Plan Nightly build run: https://buildkite.com/dagster/full-moon-with-face-dagster-nightly/builds/9
OwenKephart
pushed a commit
that referenced
this pull request
May 21, 2024
…t code on snowflake & bigquery (#21952) ## Summary Adds Snowflake & BQ tests of new row-count functionality and fixes bug with `Table` return on certain warehouses (incl Snowflake). Added to the new OSS nightly pipeline introduced in #21956 to avoid racking up unnecessary spend. We do already run some tests on these warehouses as part of normal builds for their respective integrations, so maybe it's fine to do the same here - open to either. ## Test Plan Nightly build run: https://buildkite.com/dagster/full-moon-with-face-dagster-nightly/builds/9
nikomancy
pushed a commit
that referenced
this pull request
May 22, 2024
## Summary Templates out a basic nightly OSS test to use for Snowflake integration tests w/ `dagster-dbt`, to avoid unnecessary cost.
nikomancy
pushed a commit
that referenced
this pull request
May 22, 2024
…t code on snowflake & bigquery (#21952) ## Summary Adds Snowflake & BQ tests of new row-count functionality and fixes bug with `Table` return on certain warehouses (incl Snowflake). Added to the new OSS nightly pipeline introduced in #21956 to avoid racking up unnecessary spend. We do already run some tests on these warehouses as part of normal builds for their respective integrations, so maybe it's fine to do the same here - open to either. ## Test Plan Nightly build run: https://buildkite.com/dagster/full-moon-with-face-dagster-nightly/builds/9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Templates out a basic nightly OSS test to use for Snowflake integration tests w/
dagster-dbt, to avoid unnecessary cost.