[graphql] add permissions field to WorkspaceLocationEntryStatus #21946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alangenfeld and the rest of your teammates on |
alangenfeld
commented
May 17, 2024
Comment on lines
34
to
59
| query WorkspacePermissionsQuery { | ||
| locationStatusesOrError { | ||
| __typename | ||
| ... on WorkspaceLocationStatusEntries { | ||
| entries { | ||
| permissions { | ||
| permission | ||
| value | ||
| disabledReason | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
can update this to just test both
alangenfeld
commented
May 17, 2024
Comment on lines
+157
to
+159
| def resolve_permissions(self, graphene_info): | ||
| permissions = graphene_info.context.permissions_for_location(location_name=self.name) | ||
| return [GraphenePermission(permission, value) for permission, value in permissions.items()] |
There was a problem hiding this comment.
should i deprecate or remove the other one?
There was a problem hiding this comment.
I could imagine a world in which the current one is being accessed, I have seen people asking about programatic access to the users page in cloud for example
alangenfeld
force-pushed
the
al/05-17-_graphql_add_permissions_field_to_workspacelocationentrystatus
branch
from
e10d2db
to
8ee84d7
Compare
gibsondan
approved these changes
May 20, 2024
Comment on lines
+157
to
+159
| def resolve_permissions(self, graphene_info): | ||
| permissions = graphene_info.context.permissions_for_location(location_name=self.name) | ||
| return [GraphenePermission(permission, value) for permission, value in permissions.items()] |
There was a problem hiding this comment.
I could imagine a world in which the current one is being accessed, I have seen people asking about programatic access to the users page in cloud for example
alangenfeld
force-pushed
the
al/05-17-_graphql_add_permissions_field_to_workspacelocationentrystatus
branch
from
8ee84d7
to
4dc6e70
Compare
alangenfeld
force-pushed
the
al/05-17-_graphql_add_permissions_field_to_workspacelocationentrystatus
branch
from
4dc6e70
to
8894587
Compare
alangenfeld
deleted the
al/05-17-_graphql_add_permissions_field_to_workspacelocationentrystatus
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetching these off the workspace directly blocks them on loading the whole workspace, and in some environments that is costly.
Make it available off of the other code location scoped object for faster access.
How I Tested These Changes
updated test