Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding support for Ollama local api embeddings #1384

Closed
wants to merge 13 commits into from

Conversation

KrishnaM251
Copy link
Contributor

@KrishnaM251 KrishnaM251 commented May 15, 2024

Please describe the purpose of this pull request.
See title.

How to test
poetry run pytest -s tests/test_endpoints.py

Have you tested this PR?
Yes, but it does not work yet

Related issues or PRs
Addresses #1369

Is your PR over 500 lines of code?
No.

Additional context
Current issue: Unable to connect to http://localhost:11434 when running indicated test.
This issue occured both when using LLamaIndex's interface for creating an Ollama EmbeddingModel object, and when creating a vanilla EmbeddingModel object without LLamaIndex. Do I need to have something running at http://localhost:11434 first?

IMPORTANT
The test fails when run on a file I created called ollama.json. It is containted (locally) within configs/embedding_model_configs/, however this change did not get commited (and therefore pushed) for some reason.

Here is the contents of ollama.json

{
    "embedding_endpoint_type": "ollama",
    "embedding_endpoint": "http://localhost:11434",
    "embedding_model": "mixedbread-ai/mxbai-embed-large-v1",
    "embedding_dim": 512,
    "embedding_chunk_size": 200
}

@cpacker cpacker changed the title Adding support for Ollama local api embeddings feat: Adding support for Ollama local api embeddings May 15, 2024
@cpacker
Copy link
Owner

cpacker commented May 15, 2024

@sarahwooders looks like this is the same issue popping up again with tests failing on contrib PRs

@sarahwooders sarahwooders self-requested a review May 16, 2024 23:08
@sarahwooders sarahwooders linked an issue May 16, 2024 that may be closed by this pull request
@sarahwooders
Copy link
Collaborator

moved to and merged with #1433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Support Ollama local api embeddings.
3 participants