Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zone parser error handling #6680

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rideliner
Copy link

1. Why is this pull request needed and what does it do?

Error handling for the zone parser does not follow the guidance of the dns library.

After Next returns (nil, false), the Err method will return any error that occurred during parsing.

zp.Err() will only return nil while inside the loop.

2. Which issues (if any) are related?

None

3. Which documentation changes (if any) need to be made?

None

4. Does this introduce a backward incompatible change or deprecation?

May cause an error where previously the parser would have silently stopped parsing the file.

Signed-off-by: Nathan Currier <nathan.currier@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant