Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Msty provider #916

Open
wants to merge 8 commits into
base: preview
Choose a base branch
from
Open

add Msty provider #916

wants to merge 8 commits into from

Conversation

ashokgelal
Copy link

This is the app: https://msty.app

Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit aaf6d63
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/65f9854cbc4e8d0008945e91

@sestinj
Copy link
Contributor

sestinj commented Mar 11, 2024

@ashokgelal thanks for the PR! I want to make sure I understand how Msty works before merging: is it using Ollama under the hood, or does it just match its API format? Any reason why not OpenAI? And I assume from the code here that 10000 is the default port?

@ashokgelal
Copy link
Author

It is using Ollama under the hood but maintain its own version (we check compatibility issue with the models we support, for an example) and it is also very opaque to users, if you will, as the don't have to worry about installing Ollama as we'll do that for them.
Not OpenAI because we do support local models (not sure if I interpreted your question about that correctly).

10000 is the default port but if that port is reserved by some other apps, then Msty pickup next available port.

@sestinj
Copy link
Contributor

sestinj commented Mar 17, 2024

@ashokgelal all makes sense! With the OpenAI question I was just wondering why not use the OpenAI API format, since it seems most people are moving toward that, including Ollama.

Would it be easy for you to switch the base branch of this PR from main to preview, and then I'll probably just make a few tweaks?

@ashokgelal ashokgelal changed the base branch from main to preview March 17, 2024 22:57
@ashokgelal
Copy link
Author

I just switched the base branch to preview. Feel free to make any necessary tweaks and please let me know if you need anything from my side.

Copy link
Contributor

@tgaff tgaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I'm suggesting some grammar/sentence-structure changes to improve readability.

I did also note that there's a fair bit of what might be considered mild-advertising in some of the text. e.g. "Msty is the simplest way to get started" ... "No fussing around, one-click and you are up and running."
In my opinion that's subjective, and the text would be more succinct if it were cleaned up but I've refrained from suggesting changes around that. (I'm not a maintainer and I have no horse in this race, just a few minutes spare time to read a PR today. I'll also be giving Msty a try in the next few days 😃)

docs/docs/walkthroughs/codellama.md Outdated Show resolved Hide resolved
docs/static/schemas/config.json Outdated Show resolved Hide resolved
docs/static/schemas/config.json Outdated Show resolved Hide resolved
gui/src/util/modelData.ts Outdated Show resolved Hide resolved
ashokgelal and others added 4 commits March 19, 2024 08:26
Co-authored-by: tgaff <tgaff@users.noreply.github.com>
Co-authored-by: tgaff <tgaff@users.noreply.github.com>
Co-authored-by: tgaff <tgaff@users.noreply.github.com>
Co-authored-by: tgaff <tgaff@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants