Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address some of the ruff warnings #765

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danieleades
Copy link
Contributor

i know the python implementation isn't going to be used in the long-term (i'm assuming that's still the assumption?) but in the meantime, there are errors in main that are causing CI to fail.

Consistently failing jobs means CI feedback on PRs is less meaningful.

i've squashed most of the warnings, except for these-

continuedev/libs/util/copy_codebase.py:104:18: F821 Undefined name `ManualEditAction`
continuedev/plugins/context_providers/embeddings.py:28:29: F821 Undefined name `ChromaIndexManager`
continuedev/plugins/context_providers/embeddings.py:36:34: F821 Undefined name `ChromaIndexManager`

where are these objects defined??

Copy link

netlify bot commented Jan 20, 2024

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit bd5b82a
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/65ab81f237791b00087a71a1

@sestinj
Copy link
Contributor

sestinj commented Jan 22, 2024

It looks like they are defined...nowhere. ManualEditAction is extremely old code, and I think ChromaIndexManager was a WIP, or just ended up unused.

I've moved the Python server into a separate repo so it might be okay to leave these few missing parts.

@sestinj
Copy link
Contributor

sestinj commented Jan 22, 2024

I'm happy to merge this, but it would get cleared when preview merges to main. Do you want to make a separate PR on the other repo?

@danieleades
Copy link
Contributor Author

I'm happy to merge this, but it would get cleared when preview merges to main. Do you want to make a separate PR on the other repo?

can do. might be a few days before i get a chance.

Where's the best place to track progress on the new server implementation?

@sestinj
Copy link
Contributor

sestinj commented Jan 23, 2024

No server now, everything runs in-process (Node.js) or in the sidebar (browser JS). Most things are moved to the core folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants