🩹 properly dispose of diff handler

continuedev · May 16, 2024 · 3b45028 · 3b45028
1 parent 7857c4c
commit 3b45028
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 2 deletions.
diff --git a/docs/static/schemas/config.json b/docs/static/schemas/config.json
@@ -1963,6 +1963,9 @@
               "enum": ["top", "bottom"],
               "default": "top",
               "description": "Whether to show the copy and apply code buttons at the top or bottom of code blocks in the sidebar."
+            },
+            "fontSize": {
+              "type": "number"
             }
           }
         },

diff --git a/extensions/intellij/src/main/resources/config_schema.json b/extensions/intellij/src/main/resources/config_schema.json
@@ -1963,6 +1963,9 @@
               "enum": ["top", "bottom"],
               "default": "top",
               "description": "Whether to show the copy and apply code buttons at the top or bottom of code blocks in the sidebar."
+            },
+            "fontSize": {
+              "type": "number"
             }
           }
         },

diff --git a/extensions/vscode/continue_rc_schema.json b/extensions/vscode/continue_rc_schema.json
@@ -2202,6 +2202,9 @@
               ],
               "default": "top",
               "description": "Whether to show the copy and apply code buttons at the top or bottom of code blocks in the sidebar."
+            },
+            "fontSize": {
+              "type": "number"
             }
           }
         },

diff --git a/extensions/vscode/src/diff/verticalPerLine/handler.ts b/extensions/vscode/src/diff/verticalPerLine/handler.ts
@@ -9,7 +9,7 @@ import {
 } from "./decorations";
 import { VerticalDiffCodeLens } from "./manager";
 
-export class VerticalPerLineDiffHandler {
+export class VerticalPerLineDiffHandler implements vscode.Disposable {
   private editor: vscode.TextEditor;
   private startLine: number;
   private endLine: number;
@@ -56,7 +56,7 @@ export class VerticalPerLineDiffHandler {
       this.editor,
     );
 
-    vscode.window.onDidChangeActiveTextEditor((editor) => {
+    const disposable = vscode.window.onDidChangeActiveTextEditor((editor) => {
       // When we switch away and back to this editor, need to re-draw decorations
       if (editor?.document.uri.fsPath === this.filepath) {
         this.editor = editor;
@@ -69,6 +69,7 @@ export class VerticalPerLineDiffHandler {
         this.queueDiffLine(undefined);
       }
     });
+    this.disposables.push(disposable);
   }
 
   private get filepath() {
@@ -243,6 +244,13 @@ export class VerticalPerLineDiffHandler {
 
     this.cancelled = true;
     this.refreshCodeLens();
+    this.dispose();
+  }
+
+  disposables: vscode.Disposable[] = [];
+
+  dispose() {
+    this.disposables.forEach((disposable) => disposable.dispose());
   }
 
   get isCancelled() {