Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close resource file #22404

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

testwill
Copy link
Contributor

Does this PR introduce a user-facing change?

None

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@edsantiago edsantiago added the No New Tests Allow PR to proceed without adding regression tests label Apr 17, 2024
libpod/oci_conmon_common.go Outdated Show resolved Hide resolved
Signed-off-by: guoguangwu <guoguangwug@gmail.com>
Copy link

Cockpit tests failed for commit 120660e. @martinpitt, @jelly, @mvollmer please check.

@martinpitt
Copy link
Contributor

The rawhide regression is tracked in #22417

Copy link

A friendly reminder that this PR had no activity for 30 days.

@edsantiago
Copy link
Collaborator

@containers/podman-maintainers PTAL

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, testwill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4f31335 into containers:main May 21, 2024
91 of 94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. No New Tests Allow PR to proceed without adding regression tests release-note-none stale-pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants