[v4.4.1-crio] Bump c/common to v0.52.0

[TomSweeneyRedHat]

As the title says, bumping the c/common package to v0.52.0

in the v4.4.1-crio branch via a request from the CRI-O team.

Addresses: https://issues.redhat.com/browse/OCPBUGS-32144

[NO NEW TESTS NEEDED]

Does this PR introduce a user-facing change?

None

[TomSweeneyRedHat]

@kwilczynski PTAL

This is dragging a ton of stuff in, I hope it's not too much.

[kwilczynski]

This aligns with CRI-O release 1.25. Newer releases are already on version 5.27.0 or newer.

[kwilczynski]

This aligns with CRI-O release 1.25. Newer releases are already on version 0.53.0 or newer.

[kwilczynski]

This is dragging a ton of stuff in, I hope it's not too much.

@TomSweeneyRedHat, the two most important dependencies here for us are the c/common and c/image, and updates to both look OK from our point of view.

We are good to go, I believe.

[kwilczynski]

/approve
/lgtm

[openshift-ci]

@kwilczynski: changing LGTM is restricted to collaborators

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [TomSweeneyRedHat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kwilczynski]

@TomSweeneyRedHat, even though we look good from our key dependencies point of view, we have some anciliary dependency issues per:

vendor/github.com/openshift/imagebuilder/dockerfile/parser/parser.go:122:12: undefined: system.LCOWSupported
vendor/github.com/openshift/imagebuilder/dockerfile/parser/parser.go:157:12: undefined: system.LCOWSupported

Let me have a look as to how we resolved this in CRI-O. I believe a dependency update would fix this.

[kwilczynski]

@TomSweeneyRedHat, even though we look good from our key dependencies point of view, we have some anciliary dependency issues per:

vendor/github.com/openshift/imagebuilder/dockerfile/parser/parser.go:122:12: undefined: system.LCOWSupported
vendor/github.com/openshift/imagebuilder/dockerfile/parser/parser.go:157:12: undefined: system.LCOWSupported

Let me have a look as to how we resolved this in CRI-O. I believe a dependency update would fix this.

This missing method issue has been fixed in the following release of the openshift/imagebuilder package:

• LCOWSupported method is not available in newer docker libs openshift/imagebuilder#238

We should upgrade the dependency to version 1.2.4 (a proper full release) or newer. We also use version 1.2.4 of the said package in CRI-O 1.25, where this failure does not occur.

[kwilczynski]

@TomSweeneyRedHat, if possible, this needs a version bump to:

Suggested change

	github.com/openshift/imagebuilder v1.2.4-0.20220711175835-4151e43600df
	github.com/openshift/imagebuilder v1.2.4

This looks confusing; however, it's how this project tagged their release.

[kwilczynski]

@TomSweeneyRedHat, do you think you could see about these comments:

• [v4.4.1-crio] Bump c/common to v0.52.0 #22355 (comment)
• [v4.4.1-crio] Bump c/common to v0.52.0 #22355 (comment)

To fix the build issue and potentially also move forward with this branch? I would be much obliged.

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.