Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clarify setup env for development. #64

Merged
merged 2 commits into from
May 1, 2024
Merged

docs: clarify setup env for development. #64

merged 2 commits into from
May 1, 2024

Conversation

iFurySt
Copy link
Contributor

@iFurySt iFurySt commented Apr 27, 2024 •
edited

#51

@iFurySt iFurySt requested a review from a team as a code owner April 27, 2024 09:21
@CLAassistant
Copy link

CLAassistant commented Apr 27, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

lusmoura
lusmoura approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@lusmoura lusmoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this clarification to the documentation!

@tianjing-li
Copy link
Collaborator

tianjing-li commented May 1, 2024 •
edited

@iFurySt same thing here, you'll need to resign the commits - For future PRs you can run
git config --global commit.gpgSign true to always sign

@iFurySt
docs: clarify setup env for development.
daee9c9 
Signed-off-by: ifuryst <ifuryst@gmail.com>
@iFurySt iFurySt force-pushed the docs-clarify-setup-env-for-dev branch from 3916ea7 to daee9c9 Compare May 1, 2024 15:37
@iFurySt
Copy link
Contributor Author

iFurySt commented May 1, 2024

okay, it's been updated.

@tianjing-li
Copy link
Collaborator

@iFurySt merging

@tianjing-li tianjing-li merged commit 8886432 into cohere-ai:main May 1, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lusmoura lusmoura lusmoura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iFurySt @CLAassistant @tianjing-li @lusmoura