Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: Add a code coverage % report via Check Runs API #144

Merged
merged 2 commits into from
May 24, 2024

Conversation

malexw
Copy link
Collaborator

@malexw malexw commented May 17, 2024

As part of ensuring continuing code quality, we'd like to add a check that rejects PRs if the test coverage drops too low. Part 1 of that change is just to report existing coverage on new PRs, which this change implements.

This PR isn't yet ready for review - I need to create the PR in order to test my changes.

Copy link
Contributor

@BeatrixCohere BeatrixCohere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick comment

.github/workflows/backend_tests.yml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Collaborator

@tianjing-li tianjing-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks for this

@malexw malexw merged commit 27667d6 into cohere-ai:main May 24, 2024
2 checks passed
@malexw malexw deleted the alexw/add-coverage-report branch May 24, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants