Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add (vscode-ext) language mask #6146

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

tenbits
Copy link

@tenbits tenbits commented Sep 17, 2021

Hello CSB Team,

I am working on a component-based template engine called Mask. This PR adds a new file extension (.mask) with the syntax support. It would be great, that anyone could create UI components directly from the sandbox.

What kind of change does this PR introduce?

Adds new extension for .mask files.

What is the current behavior?

.mask files are not highlighted

What is the new behavior?

.mask files have proper highlighting

What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.

  • ran dev server locally
  • added new file foo.mask with the content:
import Footer from './Footer'
define Foo extends Footer {
   if (user != null) {
       h1 > 'Hello ~[bind: user.name]'
   }
}

Checklist

Thank you, and let me know if something needs to be changed,
Best, Alex

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 17, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 88d1ceb:

Sandbox Source
Notifications Test Configuration

@lbogdan lbogdan temporarily deployed to pr6146 September 17, 2021 23:26 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Sep 17, 2021

Build for latest commit 88d1ceb is at https://pr6146.build.csb.dev/s/new.

@tenbits
Copy link
Author

tenbits commented Apr 15, 2022

Dear Team, any chance to get this merged?

I would like to start creating components demos, and the highlighting would be essential.

Thanks

@danilowoz
Copy link
Member

It looks good to me
Screenshot 2022-05-17 at 10 49 30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants