Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: re-enable test migrations in release workflow #13307

Merged
merged 2 commits into from
May 20, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented May 17, 2024

Tested here: https://github.com/coder/coder/actions/runs/9126619620/job/25095263706#step:17:101

Also makes the output "friendlier" in case of failure:

Migrating from version "9f4d2966a" to "f23d4802b" failed:
        migrate setup: create iofs: failed to init driver with path .: duplicate migration file: 000208_notification_banners.down.sql
Check the following:
 - All migrations from version "f23d4802b" must exist in version "9f4d2966a" with the same migration numbers.
 - Each migration must have the same effect.
 - There must be no gaps or duplicates in the migration numbers.

@johnstcn johnstcn requested a review from mafredri May 17, 2024 09:27
@johnstcn johnstcn self-assigned this May 17, 2024
@johnstcn johnstcn marked this pull request as draft May 17, 2024 09:32
@johnstcn johnstcn marked this pull request as ready for review May 17, 2024 10:16
@johnstcn johnstcn merged commit 45b45f1 into main May 20, 2024
35 checks passed
@johnstcn johnstcn deleted the cj/reenable-test-migrations branch May 20, 2024 09:35
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants