Shared UI package (Shadcn) and Tailwind Config consolidation #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Gautam-Hegde looks so good. Can u also migrate web(admin app) to use the same shadcn components? We do currently have shadcn there but it isn't shared. |
|
Hey also mind editing the readme with new ui package? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #29
This PR adds a shared UI package (shadcn) to the repo, along with consolidating the tailwind config in the pkg.
For the time being,
components.jsonin the shared UI package (shadcn) is avoided. Components should be added manually to have specific req.packages/ui in action(Button component)