Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove: smee-webhook-proxy #34

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

paahaad
Copy link

@paahaad paahaad commented Apr 14, 2024

AIM of this PR: remove the smee + other github app conguration.

  1. Implemented one route /webhook in express server. which will handle the event send by github.

  2. here we can add https://<server-dns-ip>:8080/webhook to github.
    webhook-add

  3. Event from github is recived in header. Perform actions based on the event type.

NOTE: we have to add this webhook to each repo. github will give the name of repo in header. This will allow to @hkirat to select which repo is eligible for bounty.

how to run in test mode.

  • we cannot add localhost address to github. so we need proxy to test. I use ngrok.
  • steps
  1. npm i -g ngrok
  2. ngrok http <PORT> poort should be your local host port

@paahaad
Copy link
Author

paahaad commented Apr 14, 2024

I do not understant the need of admin-web. he is just make entry DB and showing history. plus github webhook can be implemented in admin Nextjs API. I don't think we should be using extra proccess for this. can give me some context for this just the high level implementation.
@devsargam @hkirat

@devsargam
Copy link
Collaborator

@paahaad the admin app is currently in crude manner rn. In future, ideally it should allow maintainers to add other maintainers & add their public key, private key in the platform. Also, keep a very good record of what's going on.

@devsargam
Copy link
Collaborator

devsargam commented Apr 14, 2024

github webhook can be implemented in admin Nextjs API

Yeah but you won't get the great functionality that probot provides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants