Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for the Issue #321 , #339

Closed
wants to merge 1 commit into from
Closed

Conversation

Kunal09001
Copy link

Refactored the code for CodeBlock for changing themes and swithced themes for dark mode and light mode as well, and fixed an small issue where variable name is removed in SearchDialog which was failing builds

PR Fixes:

  • 1 Added Changes in Themes layout so it switches the themes for CodeBlock, using highlight.js vs and vs dark themes (it can be changed to others based on preferences)
  • 2 Refactored the CodeBlock so it accepts themes and conditionally importing theme files
  • 3 In SearchDialog there was empty variable name which was failing local running dev, so when checking i have added the variable name which was used in file in useRef : 'scrollableContainerRef'

Resolves #321

Checklist before requesting a review

  • [Done] I have performed a self-review of my code
  • [Done] I assure there is no similar/duplicate pull request regarding same issue

…k for accepting themes, and fixed an small issue where variable name is removed in SearchDialog which was failing builds
@hkirat
Copy link
Collaborator

hkirat commented May 21, 2024

closing because of conclifcts, please reopen if u have the time

@hkirat hkirat closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Adding Light Mode for Code Block in Tracks for the blog
2 participants