New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Persisting the Category state in the URL as query params #336

Open

nigupta29 wants to merge 2 commits into code100x:main from nigupta29:dev-category

nigupta29 commented Apr 22, 2024

Brief:

Currently, the category and filtered state has been dealt at client side.
This PR covers the handling of category filtering at server side.

Checklist before requesting a review

I have performed a self-review of my code
I assure there is no similar/duplicate pull request regarding same issue

Major Changes

Added category options to the getAllTracks util functions.
Converted Tracks component from client to server.
Moved Landing component to the main page to directly pass the searchParams to the getAllTracks.

Have a review on this PR. Thanks!

How the categories has been persisted currently.

Before.Category.state.in.url.mp4

How the categories has been persisted in this PR.

After.Category.state.in.url.mp4

nigupta29 added 2 commits

April 23, 2024 01:06


          fixed missing ref variable issue

b34dc8a


          categories state moved as url param

2e3e5a1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment