Feat search #300
Open
Feat search #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| async function createIndex(obj: algoliaobjSchema[], trackID: string) { | ||
| const client = algoliasearch(process.env.ALGOLIA_APP_ID || "", process.env.ALGOLIA_ADMIN_API_KEY || ""); | ||
| const index = client.initIndex(trackID); |
There was a problem hiding this comment.
It will be a good idea to protect API routes with auth or better use server actions instead of APIs.
I have made PR for the same issue you can check it #294
There was a problem hiding this comment.
Yes better to create server actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Fixes: #175
Dailycode.-.Google.Chrome.2024-04-18.00-03-51.1.mp4
-https://drive.google.com/file/d/17Uu64SDal69tg0wgyJlBCtMSRYGDlb9W/view?usp=sharing
Remaining (Suggestions needed):
Feature-To make change in search index whenever the notiondoc changes.
Answer - If notionApi permits a webhook like functionality. I will implement it within day. alternatively, we can add a get request to update the search index in intervals (will move with option 2 only if option 1 is not possible).
Also let me know if I am on the right track so that i can make the UI pleasing. Or did you mean something else.
Checklist before requesting a review