Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Scrollbar is not visible in light mode #244

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

karananeja
Copy link

@karananeja karananeja commented Apr 14, 2024

PR Fixes:

  • 1 Scroll bar color is updated for light mode to make it more visible

Resolves #[Issue Number if there] #240

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@vishalmishraa
Copy link
Contributor

there is lot of unwanted new lines , you can remove that , and try this code , :
just replace these

/* Scroll Bar */
::-webkit-scrollbar {
	width: 10px;
}

::-webkit-scrollbar-thumb {
  background-color: rgb(0, 0, 0);
  border-radius: 8px;
}

@hkirat
Copy link
Collaborator

hkirat commented Apr 14, 2024

Too much noise in the PR

@karananeja
Copy link
Author

karananeja commented Apr 15, 2024

@vishalmishraa

  1. I've refactored the code, and we'll need the height property for the scrollbar if the scrollbar occurs in horizontal direction
  2. The new lines are due to formatting the file, it actually had a space on each line which is formatted automatically to remove that space on each line

@hkirat
Didn't understand, what do you mean by noise?

@iamgauravbisht
Copy link

@vishalmishraa

  1. I've refactored the code, and we'll need the height property for the scrollbar if the scrollbar occurs in horizontal direction
  2. The new lines are due to formatting the file, it actually had a space on each line which is formatted automatically to remove that space on each line

@hkirat
Didn't understand, what do you mean by noise?

Remove comments from the code

@karananeja
Copy link
Author

@vishalmishraa

  1. I've refactored the code, and we'll need the height property for the scrollbar if the scrollbar occurs in horizontal direction
  2. The new lines are due to formatting the file, it actually had a space on each line which is formatted automatically to remove that space on each line

@hkirat
Didn't understand, what do you mean by noise?

Remove comments from the code

@iamgauravbisht done

@mumin-khan
Copy link
Contributor

mumin-khan commented Apr 29, 2024

@karananeja this has been fixed i guess.

@karananeja
Copy link
Author

@mumin-khan I think it's not fixed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants