Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redirect to home fixed from InHouseError page #622

Merged
merged 1 commit into from
May 21, 2024
Merged

redirect to home fixed from InHouseError page #622

merged 1 commit into from
May 21, 2024
+35 −33

Conversation

kethesainikhil
Copy link
Contributor

PR Fixes:

  • 1Redirect to Home when you go to any notlisted routes
  • 2Previously the routing is not up to the mark as it was created by me only so I fixed the error and appologize for not taking care of routing.

Resolves #[Issue Number if there]

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue
    Below is the screen recording of before and after this pull request
    Screencast from 2024-05-14 11-44-10.webm

@hkirat hkirat merged commit 7368c83 into code100x:main May 21, 2024
1 check passed
@hkirat
Copy link
Contributor

hkirat commented May 21, 2024

Thankyou!

Dishant1804 added a commit to Dishant1804/cms that referenced this pull request May 23, 2024
@Dishant1804
Revert "Merge pull request code100x#622 from kethesainikhil/erorr/red…
542540d 
…irect"

This reverts commit 7368c83, reversing
changes made to e69cef4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kethesainikhil @hkirat