New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: setup logic for resign
& offer draw
#180
Conversation
nice |
I tried implementing this but failed :( |
Hey @hkirat, could you please review this one? |
} | ||
|
||
if (message.type === DRAW_OFFER_ACCEPTED) { | ||
SocketManager.getInstance().broadcast( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we checking if the other user has offered a draw before accepting it?
It should be stored somewhere that there was an offer made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good one. I thought better do this way since doing db was a lot of hassle. Happy to change if needed? is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hkirat how about a in memory store the expires every 30s?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In memory yeah makes sense
Hey @hkirat kindly check this one. A lot of ui changes very prone to merge conflicts |
Ui can be extended from #223 |
#223 is merged |
@hkirat new one should do it. Raising it by eod |
No description provided.