ttljob: don't block job completion on stats queries #124306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafiss
added
backport-23.1.x
|
This change is |
There was a problem hiding this comment.
LGTM!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @annrpom)
annrpom
approved these changes
May 23, 2024
Dedej-Bergin
approved these changes
May 23, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:
Release note (bug fix): Previously, if the ttl_row_stats_poll_interval storage parameter was non-zero for a table with row level TTL enabled, the queries issued to update row stats could block the job from completing. Now, if the job completes, these stats queries are cancelled instead. This means that the jobs.row_level_ttl.total_rows and jobs.row_level_ttl.total_expired_rows metrics will report 0 if the job finishes before the row stats queries complete.
done thanks for the reviews! bors r+ |
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #124305
Release note (bug fix): Previously, if the ttl_row_stats_poll_interval
storage parameter was non-zero for a table with row level TTL enabled,
the queries issued to update row stats could block the job from
completing. Now, if the job completes, these stats queries are cancelled
instead. This means that the jobs.row_level_ttl.total_rows and
jobs.row_level_ttl.total_expired_rows metrics will report 0 if the job
finishes before the row stats queries complete.