Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: switch md5 cmd name based on existence #124293

Merged
merged 1 commit into from
May 21, 2024
Merged

tools: switch md5 cmd name based on existence #124293

merged 1 commit into from
May 21, 2024

Conversation

dt
Copy link
Member

@dt dt commented May 16, 2024

Release note: none.
Epic: none.

@dt dt requested a review from rickystewart May 16, 2024 19:50
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart
Copy link
Collaborator

rickystewart commented May 16, 2024 •
edited

Hmm, just a thought, I think my preferred solution would be to simply check which md5 and fall back to md5sum if it is not available (or vice-versa). The OS doesn't really matter except when it comes to how the two binaries that do the same thing are named. We can simply check whether the binaries are installed. (This is fine, you can still merge it.)

@dt
tools: switch md5 cmd name based on uname
1304f42 
Release note: none.
Epic: none.
@dt dt changed the title tools: switch md5 cmd name based on uname tools: switch md5 cmd name based on existence May 21, 2024
@dt
Copy link
Member Author

dt commented May 21, 2024 •
edited

TFTR!

simply check which md5

Good point, done.

bors r+

craig bot pushed a commit that referenced this pull request May 21, 2024
@dt
Merge #124293
a462dc0 
124293: tools: switch md5 cmd name based on existence  r=dt a=dt

Release note: none.
Epic: none.

Co-authored-by: David Taylor <tinystatemachine@gmail.com>
@craig
Copy link
Contributor

craig bot commented May 21, 2024

Timed out.

@dt
Copy link
Member Author

dt commented May 21, 2024

bors r+

@craig
Copy link
Contributor

craig bot commented May 21, 2024

Build succeeded:

@craig craig bot merged commit 7807ee2 into cockroachdb:master May 21, 2024
22 checks passed
@dt dt deleted the darwin-md5 branch May 21, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickystewart rickystewart rickystewart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dt @cockroach-teamcity @rickystewart