upgradecluster: retry until cluster stable with unavailable nodes #124288
+49
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Nodes can be transiently unavailable (failing a heartbeat), in which case the upgrade manager will error out. Retry `UntilClusterStable` for up to 10 times when there are unavailable nodes before returning an error. Resolves: cockroachdb#120521 Resolves: cockroachdb#121069 Resolves: cockroachdb#119696 Release note: None
kvoli
force-pushed
the
240513.retry-unavailable-upgradecluster
branch
from
7e7ae23
to
ab76750
Compare
rafiss
reviewed
May 31, 2024
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andrewbaptist and @kvoli)
pkg/upgrade/upgradecluster/cluster.go line 79 at r1 (raw file):
unavailableRetries := 0 for {
nit: would a retry ctx make sense here?
retryOpts := base.DefaultRetryOptions()
retryOpts.MaxRetries = 10
for r := retry.StartWithCtx(ctx, retryOpts); r.Next(); {
// ...
}
pkg/upgrade/upgradecluster/cluster.go line 111 at r1 (raw file):
} if len(unavailable) > 0 { return 0, errors.Newf("unavailable node(s): %v", unavailable)
is there any concern that this would create a new error scenario that didn't exist before (asking since we'd want to backport this)? or is it just that this problem could already happen, but returning the error here is more clear?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodes can be transiently unavailable (failing a heartbeat), in which case the upgrade manager will error out. Retry
UntilClusterStablefor up to 10 times when there are unavailable nodes before returning an error.Resolves: #120521
Resolves: #121069
Resolves: #119696
Release note: None