h3: set stream priority after headers buffered #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
send_headers() can fail if there is not enough stream capacity to buffer encoded headers and applications are expected to try again later. Previously, send_response_with_priority() would update the stream priority prior to send_headers(), which might surprise some types of applications relying on the writable() iterator. This change swaps the ordering around so that priority is only changed after headers have been successfully buffered.
ghedo
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
send_headers() can fail if there is not enough stream capacity to buffer
encoded headers. Applications are expected to try again later.
Previously, send_response_with_priority() would update
the stream priority prior to send_headers(), which might surprise
some types of applications relying on the writable() iterator.
This change swaps the ordering around so that priority is only changed
after headers have been successfully buffered.