Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish TODO: zip #214

Closed
wants to merge 1 commit into from
Closed

Finish TODO: zip #214

wants to merge 1 commit into from

Conversation

cospectrum
Copy link
Contributor

No description provided.

@johnhurt
Copy link
Contributor

johnhurt commented Apr 26, 2024 •
edited

This looks like excellent work! There's a lot going on in this pr. My recommendation is to break it down in to a few smaller prs tackling one todo at a time. Also make sure your commit doesn't include changes to the .bleep file. That's our marker for keeping this repo in sync with our working copy.

Edit. Oops, ignore the above. I think this commit just needs to be rebased on the new main branch. We had an issue last week where all the commits form contributors got squashed and we had to fix it manually. The actual code change here looks great 👍

@johnhurt johnhurt added Changes Requested A reviewer has requested changes to this PR enhancement New feature or request labels Apr 26, 2024
@cospectrum
Copy link
Contributor Author

Rebased

@cospectrum cospectrum changed the title Finish zip todo Finish TODO: zip Apr 26, 2024
@johnhurt
Copy link
Contributor

Love it. Thanks!

@johnhurt johnhurt added Accepted This change is accepted by us and merged to our internal repo and removed Changes Requested A reviewer has requested changes to this PR labels Apr 30, 2024
eaufavor pushed a commit that referenced this pull request May 10, 2024
@cospectrum @johnhurt
finish zip todo
f408d22 
Includes-commit: 68a9196
Replicated-from: #214
eaufavor pushed a commit that referenced this pull request May 10, 2024
@cospectrum @eaufavor
finish zip todo
4347ef4 
Includes-commit: 68a9196
Replicated-from: #214
@eaufavor
Copy link
Member

Now available in 4347ef4. Thanks!

@eaufavor eaufavor closed this May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Accepted This change is accepted by us and merged to our internal repo enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cospectrum @johnhurt @eaufavor