expose new_uds err

cloudflare · Apr 21, 2024 · 7345c17 · 7345c17
1 parent 845c30d
commit 7345c17
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/pingora-core/src/upstreams/peer.rs b/pingora-core/src/upstreams/peer.rs
@@ -400,9 +400,9 @@ impl HttpPeer {
     }
 
     /// Create a new [`HttpPeer`] with the given path to Unix domain socket and TLS settings.
-    pub fn new_uds(path: &str, tls: bool, sni: String) -> Self {
-        let addr = SocketAddr::Unix(UnixSocketAddr::from_pathname(Path::new(path)).unwrap()); //TODO: handle error
-        Self::new_from_sockaddr(addr, tls, sni)
+    pub fn new_uds(path: &str, tls: bool, sni: String) -> std::io::Result<Self> {
+        let addr = SocketAddr::Unix(UnixSocketAddr::from_pathname(Path::new(path))?);
+        Ok(Self::new_from_sockaddr(addr, tls, sni))
     }
 
     /// Create a new [`HttpPeer`] that uses a proxy to connect to the upstream IP and port

diff --git a/pingora-proxy/tests/utils/server_utils.rs b/pingora-proxy/tests/utils/server_utils.rs
@@ -232,11 +232,9 @@ impl ProxyHttp for ExampleProxyHttp {
     ) -> Result<Box<HttpPeer>> {
         let req = session.req_header();
         if req.headers.contains_key("x-uds-peer") {
-            return Ok(Box::new(HttpPeer::new_uds(
-                "/tmp/nginx-test.sock",
-                false,
-                "".to_string(),
-            )));
+            return Ok(Box::new(
+                HttpPeer::new_uds("/tmp/nginx-test.sock", false, "".to_string()).unwrap(),
+            ));
         }
         let port = req
             .headers