More trace logs for TX locking #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfops
commented
Jun 3, 2024
| let res = f(&mut tx); | ||
| self.inner.release_tx(ctx, tx); | ||
| self.release_tx(ctx, tx); |
There was a problem hiding this comment.
these are so we get the log messages consistently
bfops
commented
Jun 3, 2024
| @@ -125,7 +125,7 @@ impl SubscriptionManager { | |||
| let tables = &event.status.database_update().unwrap().tables; | |||
| let slow = db.read_config().slow_query; | |||
| let tx = scopeguard::guard(db.begin_tx(), |tx| { | |||
| tx.release(&ExecutionContext::incremental_update(db.address(), slow)); | |||
| db.release_tx(&ExecutionContext::incremental_update(db.address(), slow), tx); | |||
There was a problem hiding this comment.
so we get the log messages consistently
bfops
commented
Jun 3, 2024
| @@ -300,7 +304,7 @@ impl RelationalDB { | |||
|
|
|||
| #[tracing::instrument(skip_all)] | |||
| pub fn release_tx(&self, ctx: &ExecutionContext, tx: Tx) { | |||
| log::trace!("ROLLBACK TX"); | |||
| log::trace!("RELEASE TX"); | |||
There was a problem hiding this comment.
I think this was a typo?
bfops
commented
Jun 3, 2024
| } | ||
|
|
||
| #[tracing::instrument(skip_all)] | ||
| pub fn begin_tx(&self) -> Tx { | ||
| log::trace!("BEGIN TX"); | ||
| self.inner.begin_tx() | ||
| let r = self.inner.begin_tx(); | ||
| log::trace!("ACQUIRED TX"); |
There was a problem hiding this comment.
when we were debugging lock issues, we appreciated not only having a "trying to acquire lock" message but also a "I am now holding the lock" message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Some small changes to make the trace logs more consistent for tx locks.
API and ABI breaking changes
Nope
Expected complexity level and risk
1
Testing
This is a holdover from a debugging session. It was tested-by-fire.