Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table::get_fixed_row -> RowRef::get_row_data + Some docs #1250

Merged
merged 1 commit into from
May 20, 2024
Merged

Table::get_fixed_row -> RowRef::get_row_data + Some docs #1250

merged 1 commit into from
May 20, 2024

Conversation

Centril
Copy link
Contributor

@Centril Centril commented May 17, 2024

Description of Changes

  • Remove Table::get_fixed_row.
  • Add RowRef::get_row_data and use it.
  • Add some docs to nearby methods.

API and ABI breaking changes

None

Expected complexity level and risk

1

@Centril
- Table::get_fixed_row -> RowRef::get_row_data
364b033 
- Document some table methods
@Centril Centril added this pull request to the merge queue May 20, 2024
Merged via the queue into master with commit 0b89165 May 20, 2024
7 checks passed
@Centril Centril deleted the centril/rowref-get_row_data branch May 20, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shubham8287 Shubham8287 Shubham8287 approved these changes

@gefjon gefjon Awaiting requested review from gefjon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Centril @Shubham8287