Flatten ColumnOp, avoiding allocation in the common case
#1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/flatten-columnop
branch
from
8944135
to
333eee8
Compare
Centril
force-pushed
the
centril/columnop-with-colid
branch
from
24686b5
to
74f913e
Compare
Centril
force-pushed
the
centril/flatten-columnop
branch
from
333eee8
to
119544e
Compare
Centril
force-pushed
the
centril/columnop-with-colid
branch
from
74f913e
to
13eca30
Compare
Centril
force-pushed
the
centril/flatten-columnop
branch
from
119544e
to
ca9574b
Compare
Centril
force-pushed
the
centril/columnop-with-colid
branch
from
13eca30
to
9227167
Compare
Centril
force-pushed
the
centril/flatten-columnop
branch
from
ca9574b
to
bb15318
Compare
joshua-spacetime
approved these changes
Jun 3, 2024
Centril
force-pushed
the
centril/columnop-with-colid
branch
from
9227167
to
aed0b12
Compare
Centril
force-pushed
the
centril/flatten-columnop
branch
from
bb15318
to
8614716
Compare
cloutiertyler
added
release-0.10
and removed
release-any
Centril
force-pushed
the
centril/flatten-columnop
branch
from
8614716
to
accb7c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes #1113.
See that ticket for a description of the idea.
This PR does the
ColumnOpflattening part (2) while #1207 upon which this is based does the position part (1).API and ABI breaking changes
None
Expected complexity level and risk
1