Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coverage report action #2219

Merged
merged 3 commits into from
May 19, 2024
Merged

Update coverage report action #2219

merged 3 commits into from
May 19, 2024

Conversation

kuhnroyal
Copy link
Member

The new version now supports listing individual changed files, not just packages and adds a flag that hides all files without changes to the coverage. We use that for the PR comment.

With VannaDii/pub-dev#9 the cobertura package now also reports the correct line coverage.

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

@kuhnroyal kuhnroyal self-assigned this May 17, 2024
@kuhnroyal kuhnroyal requested a review from a team as a code owner May 17, 2024 23:58
@kuhnroyal
Copy link
Member Author

The test failures are unrelated. Not sure whats going on there.

@kuhnroyal
Copy link
Member Author

This will hopefully work once #2221 is on the default branch.

Copy link
Contributor

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
plugins/http2_adapter/lib/src/connection_manager_imp.dart 🟠 60.47% 🟢 79.84% 🟢 19.37%
Overall Coverage 🟢 80.58% 🟢 81.41% 🟢 0.83%

Minimum allowed coverage is 0%, this run produced 81.41%

@ueman ueman merged commit 0eab30a into cfug:main May 19, 2024
3 checks passed
@kuhnroyal
Copy link
Member Author

Not sure what happened to the coverage comment. It shows changes in one file. We will have to keep an eye out for that. But seems to work in general.

@kuhnroyal kuhnroyal deleted the coverage branch May 19, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants