rgw: only consider subuser perm for its user resources #57539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, subusers inherit ACL permissions from the parent account, and the permission check using `op_to_perm()`, performed before considering the resource (bucket/object) ACLs, may deny access even if the resource has authenticated or public read/write permissions. Since ACLs do not support subusers, a subuser's permissions should only be considered for resources owned by their user. For accessing other resources, subusers should only be granted access if public read/write permissions are available. Fixes: https://tracker.ceph.com/issues/66105 Signed-off-by: Seena Fallah <seenafallah@gmail.com>
clwluvw
commented
May 22, 2024
| // Only consider ACL if the user has full control (either a subuser with full control or a non-subuser) | ||
| perm = acl.get_perm(dpp, auth_identity, perm_mask); | ||
|
|
||
| if (auth_identity.is_owner_of(owner.id)) { |
There was a problem hiding this comment.
Regarding the recent account implementation, this probably needs to be replaced by something like this: is_root_of() 06a2645#diff-086b6cb87149dc85d4a1160169c614771a444abeefd5cb6730a3bf65155df825R64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, subusers inherit ACL permissions from the parent account, and the permission check using
op_to_perm(),performed before considering the resource (bucket/object) ACLs, may deny access even if the resource has authenticated or public read/write permissions. Since ACLs do not support subusers, a subuser's permissions should only be considered for resources owned by their user.
For accessing other resources, subusers should only be granted access if public read/write permissions are available.
Fixes: https://tracker.ceph.com/issues/66105