Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ptl-tool: allow not pushing branch to ceph-ci #57529

Merged
merged 1 commit into from
May 21, 2024
Merged

ptl-tool: allow not pushing branch to ceph-ci #57529

merged 1 commit into from
May 21, 2024

Conversation

rishabh-d-dave
Copy link
Contributor

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@rishabh-d-dave
Copy link
Contributor Author

Tested this change, works fine for me.

@rishabh-d-dave
Copy link
Contributor Author

@batrick Is there anybody else who should be added as the reviewer? Can't think of anybody.

@rishabh-d-dave rishabh-d-dave force-pushed the ptl-no-ceph-ci-push branch 2 times, most recently from 486a05b to b995120 Compare May 16, 2024 17:39
@rishabh-d-dave
Copy link
Contributor Author

Tested it, it works fine.

batrick
batrick requested changes May 16, 2024
View reviewed changes
src/script/ptl-tool.py Outdated Show resolved Hide resolved
src/script/ptl-tool.py Show resolved Hide resolved
@rishabh-d-dave rishabh-d-dave force-pushed the ptl-no-ceph-ci-push branch 2 times, most recently from bfb46aa to a6af280 Compare May 16, 2024 18:46
batrick
batrick requested changes May 16, 2024
View reviewed changes
src/script/ptl-tool.py Outdated
# Merging all PRs labeled 'wip-pdonnell-testing' into a new test branch but
# NOT pushing that branch to ceph-ci repo:
#
# $ src/script/ptl-tool.py --pr-label wip-pdonnell-testing --branch main --no-build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# $ src/script/ptl-tool.py --pr-label wip-pdonnell-testing --branch main --no-build
# $ src/script/ptl-tool.py --pr-label wip-pdonnell-testing --branch main --create-qa --no-push-ci

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It bears mentioning that we only push to ci if creating or updating a qa ticket.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, done, added a mention for this. (I think, technically, this should be separate note elsewhere)

@rishabh-d-dave rishabh-d-dave force-pushed the ptl-no-ceph-ci-push branch 2 times, most recently from ddbae1e to f40abdd Compare May 16, 2024 20:20
@rishabh-d-dave
Copy link
Contributor Author

jenkins test api

@rishabh-d-dave
Copy link
Contributor Author

jenkins test windows

@rishabh-d-dave
Copy link
Contributor Author

https://jenkins.ceph.com/job/ceph-windows-pull-requests/40348/

@rishabh-d-dave
Copy link
Contributor Author

jenkins test windows

@rishabh-d-dave
Copy link
Contributor Author

https://jenkins.ceph.com/job/ceph-windows-pull-requests/40359/

@rishabh-d-dave
Copy link
Contributor Author

jenkins test windows

@rishabh-d-dave
Copy link
Contributor Author

https://jenkins.ceph.com/job/ceph-windows-pull-requests/40377/console

Build step 'Execute shell' marked build as failure
Archiving artifacts
[PostBuildScript] - [INFO] Executing post build scripts.
[ceph-windows-pull-requests] $ /bin/bash /tmp/jenkins4399865873181019505.sh
+ set -o errexit
+ set -o pipefail
+ delete_libvirt_vms
++ sudo virsh list --all --name
+ libvirt_vms='ceph-ubuntu-vstart-ceph-windows-pull-requests-40337
ceph-windows-client-ceph-windows-pull-requests-40337'
+ for vm in $libvirt_vms
+ sudo virsh destroy ceph-ubuntu-vstart-ceph-windows-pull-requests-40337
Domain 'ceph-ubuntu-vstart-ceph-windows-pull-requests-40337' destroyed

+ sudo virsh managedsave-remove ceph-ubuntu-vstart-ceph-windows-pull-requests-40337
Domain 'ceph-ubuntu-vstart-ceph-windows-pull-requests-40337' has no manage save image; removal skipped
+ sudo virsh undefine ceph-ubuntu-vstart-ceph-windows-pull-requests-40337
Domain 'ceph-ubuntu-vstart-ceph-windows-pull-requests-40337' has been undefined

+ for vm in $libvirt_vms
+ sudo virsh destroy ceph-windows-client-ceph-windows-pull-requests-40337
Domain 'ceph-windows-client-ceph-windows-pull-requests-40337' destroyed

+ sudo virsh managedsave-remove ceph-windows-client-ceph-windows-pull-requests-40337
Domain 'ceph-windows-client-ceph-windows-pull-requests-40337' has no manage save image; removal skipped
+ sudo virsh undefine ceph-windows-client-ceph-windows-pull-requests-40337
Domain 'ceph-windows-client-ceph-windows-pull-requests-40337' has been undefined

+ sudo find /var/lib/libvirt/images/ -type f -delete
+ sudo virsh pool-refresh default
error: failed to get pool 'default'
error: Storage pool not found: no storage pool with matching name 'default'

+ true
+ clear_libvirt_networks
++ sudo virsh net-list --all --name
+ networks=default
+ for network in $networks
+ sudo virsh net-destroy default
Network default destroyed

+ sudo virsh net-undefine default
Network default has been undefined

+ sudo rm -rf /home/jenkins-build/build/workspace/ceph-windows-pull-requests/ceph /home/jenkins-build/build/workspace/ceph-windows-pull-requests/ceph_vstart /home/jenkins-build/build/workspace/ceph-windows-pull-requests/ceph.zip /home/jenkins-build/build/workspace/ceph-windows-pull-requests/libvirt
[Checks API] No suitable checks publisher found.
Setting status of f40abdde1de8687b910d5b42ecc18a7333f86aff to FAILURE with url https://jenkins.ceph.com/job/ceph-windows-pull-requests/40377/ and message: 'ceph windows tests failed
 '
Using context: ceph windows tests
Finished: FAILURE

@rishabh-d-dave
src/ptl-tool: allow not pushing branch to ceph-ci
b59202a 
Sometimes we need a branch but don't want to launch builds on shaman for
it. For such cases, provide an option that allows not pushing the branch
to ceph-ci.

Creating a branch that'll only be passed to "teuthology-suite" option
"--suite-branch" is an example of such a case.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave rishabh-d-dave merged commit a7d580f into ceph:main May 21, 2024
11 checks passed
@rishabh-d-dave rishabh-d-dave deleted the ptl-no-ceph-ci-push branch May 21, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batrick batrick batrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rishabh-d-dave @batrick