chore: Convert actions to Kotlin #482
Conversation
| TelemetryAction.IDE_ACTION | ||
| .createActionMessage() | ||
| .property("group", null) | ||
| .property("action", actionType.name) | ||
| .send() |
There was a problem hiding this comment.
Logic changed: Success or Failure telemetry, not both (therefore properties added to error too).
But I can revert if both are needed in case of an error 😅
| } | ||
|
|
||
| override fun actionPerformed(project: Project, editor: Editor, selectedText: String?) { | ||
| if (!selectedText.isNullOrBlank()) { |
There was a problem hiding this comment.
Changed empty to blank
| "Staged git diff" to stagedGitDiff, | ||
| "New files" to newFilesContent) | ||
| .entries.stream() | ||
| .filter { !it.value.isNullOrBlank() } |
There was a problem hiding this comment.
Changed empty to blank
|
|
||
| fun updateState(checkedNode: CheckedTreeNode) { | ||
| val fileContent = getNodeFileContent(checkedNode) ?: return | ||
| val tokenCount = encodingManager.countTokens(fileContent) |
There was a problem hiding this comment.
I would do nothing if tokenCount == 0 (for example if an error occured) 😅
| .send() | ||
| } | ||
| } | ||
| onRefresh.run() |
There was a problem hiding this comment.
Why call onRefresh if event.project == null? 🤔
Why show a dialog if nothing can be done? 😉
| } | ||
|
|
||
| override fun actionPerformed(event: AnActionEvent) { | ||
| if (OverlayUtil.showDeleteConversationDialog() == Messages.YES && event.project != null) { |
There was a problem hiding this comment.
Why show a dialog if event.project == null? 😅
| if (OverlayUtil.showDeleteConversationDialog() == Messages.YES && event.project != null) { | |
| if (event.project != null && OverlayUtil.showDeleteConversationDialog() == Messages.YES) { |
| TelemetryAction.IDE_ACTION.createActionMessage() | ||
| .property("action", ActionType.OPEN_CONVERSATION_IN_EDITOR.name) | ||
| .send() |
There was a problem hiding this comment.
Telemetry if nothing happend (e.project == null or getCurrentConversation() == null)? 🤔
reneleonhardt
force-pushed
the
convert-actions-to-kotlin
branch
2 times, most recently
from
d00c766
to
ed6f96f
Compare
|
@carlrobertoh I converted |
|
I haven't had a chance to review this PR yet, but I'll try to do it sometime early next week. Also, I'll probably do the next release without these refactorings because our test coverage is bad, and I don't want to risk breaking anything. |
|
Sounds good 👍 |
|
Speaking of which, please try Llama 3 locally first before releasing 😅 |
|
The response seems a bit off. Also, the success callback isn't being triggered once the server is up and running, so it looks like it's booting up forever. 
|
|
Was able to fix the response by modifying the prompt and adding a stop token. 
|
|
Thank you for testing and fixing! Stream was not the problem, |
I followed the template format from their official guide. Even if it's not required, I'd still like to have it included unless it breaks something.
I called it a hack because the way we detect if the server is up and running is through the server logs. I assume they changed their logging structure (from |
|
Hey, I'm putting this refactoring on pause for a bit until I have run a compatibility comparison between different IDE builds. Most likely, this won't cause any issues, but I just want to be sure, since I'm slowly considering supporting older versions again. |
reneleonhardt
force-pushed
the
convert-actions-to-kotlin
branch
3 times, most recently
from
2c68fde
to
a24a6b6
Compare
reneleonhardt
force-pushed
the
convert-actions-to-kotlin
branch
from
a24a6b6
to
9f09aaf
Compare
I suggest streamlining all
actionPerformed:requireNonNull()or handle null accordingly?