Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add floating ui to dropdown #16492

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

preetibansalui
Copy link
Contributor

Closes #15865

Implement Floating UI in Dropdown

Changed

Implement floating ui in Dropdown

Copy link

netlify bot commented May 17, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4188d60
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/666065a2d24496000846f3b6
😎 Deploy Preview https://deploy-preview-16492--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@2nikhiltom 2nikhiltom changed the title feat: implement floating ui to dropdown feat: Add floating ui to dropdown May 21, 2024
Copy link

netlify bot commented May 22, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 4188d60
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/666065a218baea0008747c85
😎 Deploy Preview https://deploy-preview-16492--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AustinGitHub
Copy link
Contributor

Hi @preetibansalui do you know what the status of this PR is and ETA of it being merged in? I am told that this will resolve an issue with the scrolling issue when we use a dropdown that would resolve an issue like this #7565

Thanks!

Copy link
Contributor

@riddhybansal riddhybansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need an autoalign prop in this ? Autoalignment should not be conditional in case of dropdown. Floating UI should be added to it by default. @tay1orjones What are your views on this ?

@preetibansalui
Copy link
Contributor Author

Do we really need an autoalign prop in this ? Autoalignment should not be conditional in case of dropdown. Floating UI should be added to it by default. @tay1orjones What are your views on this ?

As discussed on Slack, we are keeping autoAlign Prop as of now.

Copy link
Contributor

@riddhybansal riddhybansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM !!!

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Do we want to set autoAlign to true in all of the Modal stories and not just the Playground?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add floating-ui to @carbon/react Dropdown
5 participants