Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add floating-ui to @carbon/react Dropdown #15865

Open
6 tasks
Tracked by #14139
tay1orjones opened this issue Mar 1, 2024 · 0 comments · May be fixed by #16492
Open
6 tasks
Tracked by #14139

Add floating-ui to @carbon/react Dropdown #15865

tay1orjones opened this issue Mar 1, 2024 · 0 comments · May be fixed by #16492

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Mar 1, 2024

Similar to how we've updated Popover to use floating-ui for autoAlign positioning, the Dropdown needs to have this as well.

At a high level this includes:

  • Adding an autoAlign prop to Dropdown that should turn off most/all listbox styling
  • This might also require altering the ListBox and it's related components as well, adding autoAlign to those components to turn off styling.
  • When autoAlign is used, only the top or bottom alignment options should be used
  • Add an autoAlign story to the
  • Once complete, validate that Dropdown is no longer clipped by modals or any other parent container with overflow: hidden - document this in storybook for review (can be removed before merging)
  • Ideally this could also include some new abstractions of common code shared between the floating-ui implementation of Popover and Dropdown, to be further used when adding floating-ui functionality to other components.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🚦 In Review
Development

Successfully merging a pull request may close this issue.

3 participants