Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Added -a flag to the stop command #3529

Closed
wants to merge 1 commit into from

Conversation

rogkne
Copy link

@rogkne rogkne commented May 16, 2024

Adds the -a flag in addition to the already existing --all flag to the sub command stop.

This provides a more consistent help output and it is handy for regular use:

Options:
  -h, --help         Displays help on commandline options
  -v, --verbose      Increase logging verbosity. Repeat the 'v' in the short
                     option for more detail. Maximum verbosity is obtained with
                     4 (or more) v's, i.e. -vvvv.
  -a, --all          Stop all instances
  -t, --time <time>  Time from now, in minutes, to delay shutdown of the
                     instance
  -c, --cancel       Cancel a pending delayed shutdown

Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rogkne, thank you for the PR and your interest in Multipass.

The absence of -a is intentional here. I know it is a little bit more effort, but the goal is to require a more conscious decision on the part of the user to affect all instances at once. And we want the flag to be consistent across commands (e.g. start, delete)

@rogkne
Copy link
Author

rogkne commented May 24, 2024

Thanks @ricab for the clarification. I close the PR.

@rogkne rogkne closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants