-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect encryption string instructions #15086
base: main
Are you sure you want to change the base?
Conversation
@lucasjohnston is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Graphite Automations"Add community label" took an action on this PR • (05/17/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (05/17/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This PR is being marked as stale due to inactivity. |
What does this PR do?
As outlined in #13290, any new calcom user following the .env example is unable to perform any administrative function as 2FA is required.
Because
"latin1"
is specified as the encryption/decryption method inlib/crypto.ts
, using a base64 encoded string (as is currently suggested) results in a 44 length string, which breaks the 2FA process.A cleaner solution would be to update
crypto.ts
directly, but this was already rejected in #13484 in favour of the ongoing refactor in #12698. This PR is a temporary fix until the larger refactor has been completed.Mandatory Tasks