Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: org-wide workflows #15083

Draft
wants to merge 98 commits into
base: main
Choose a base branch
from
Draft

feat: org-wide workflows #15083

wants to merge 98 commits into from

Conversation

CarinaWolli
Copy link
Member

@CarinaWolli CarinaWolli commented May 16, 2024

What does this PR do?

Org-workflow can be set active on teams and will trigger for all the team's event type + all the user event types of the team members.

workflows/update.handler is refactored into smaller functions that can be reused and tested.

Loom Video: https://www.loom.com/

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

Basic test:

  • Create and org workflow
  • Set active on a team (or all teams)
  • Book a team event type --> see if workflow triggers
  • Book a user event type of a team member --> see if workflow triggers

Test other cases, for example:

  • test with several teams when some team members are part of several teams --> a workflow should always just trigger once
  • Test updating a 'before event' workflow and see if WorkflowReminders are correctly adjusted
    • delete reminders if team is removed from workflow (but if user is still part of another team that is active, the reminder should stay)
  • delete/add reminders for deleted/added steps
  • Add reminders for new active teams
  • Test if 'active on all teams/even-types, including future ones' works with new event types/teams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO High priority Created by Linear-GitHub Sync ❗️ migrations contains migration files organizations area: organizations, orgs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3489] org-wide workflows
2 participants