feat: outlook 365 calendar endpoints #15077

Ryukemeister · 2024-05-16T11:21:47Z

What does this PR do?

This PR adds the endpoints for the microsoft outlook calendar. The frontend can be done in a follow PR once the endpoints are merged. Also added some e2e tests for case where access token or origin might be invalid and also when all the credentials are good

…s and redirect url for office 365 calendar

linear · 2024-05-16T11:21:50Z

CAL-3544 Outlook/office365 Integration - Connect Atom

github-actions · 2024-05-16T11:22:01Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

socket-security · 2024-05-16T11:22:57Z

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note
Install scripts	npm/esbuild@0.20.2	Install script: postinstall Source: `node install.js`

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@SocketSecurity ignore npm/esbuild@0.20.2

…connect-atom

vercel · 2024-05-16T11:23:47Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments

Name	Status	Preview	Updated (UTC)
ai	⬜️ Ignored (Inspect)	Visit Preview	Jun 3, 2024 10:14am
cal	⬜️ Ignored (Inspect)	Visit Preview	Jun 3, 2024 10:14am
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview	Jun 3, 2024 10:14am

graphite-app · 2024-05-16T11:25:11Z

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (05/16/24)

1 reviewer was added to this PR based on Keith Williams's automation.

github-actions · 2024-05-16T11:34:25Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2024-05-16T11:35:58Z

Current Playwright Test Results Summary

✅ 42 Passing - ❌ 1 Failing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/17/2024 08:47:50pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: ddcdddb

Started: 05/17/2024 08:46:42pm UTC

❌ Failures

📄 apps/web/playwright/teams.e2e.ts • 1 Failure

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Teams - NonOrg -- future Can create a booking for Round Robin EventType Retry 2 • Retry 1 • Initial Attempt Error: expect(received).toBe(expected) // Object.is equality... `expect(received).toBe(expected) // Object.is equality Expected: true Received: false`	6.82% (18) 18 / 264 runs failed over last 7 days	25% (66) 66 / 264 runs flaked over last 7 days

⚠️ Flakes

📄 apps/web/playwright/signup.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Signup Flow Test Email verification sent if enabled Retry 1 • Initial Attempt	1.13% (3) 3 / 266 runs failed over last 7 days	24.44% (65) 65 / 266 runs flaked over last 7 days

View Detailed Build Results

ThyMinimalDev · 2024-05-31T10:39:07Z

apps/api/v2/src/ee/calendars/services/gcal.service.ts

+    const origin = req.get("origin") ?? req.get("host");
+    const redirectUrl = await await this.getCalendarRedirectUrl(accessToken, origin ?? "");
+
+    return { status: "SUCCESS", data: { authUrl: redirectUrl } };


{ status: SUCCESS_STATUS, data: { authUrl: redirectUrl } };

ThyMinimalDev · 2024-05-31T10:39:33Z

apps/api/v2/src/ee/calendars/services/outlook.service.ts

+    const origin = req.get("origin") ?? req.get("host");
+    const redirectUrl = await await this.getCalendarRedirectUrl(accessToken, origin ?? "");
+
+    return { status: "SUCCESS", data: { authUrl: redirectUrl } };


SUCCESS_STATUS

…connect-atom

changes done

Ryukemeister added 10 commits May 14, 2024 11:41

init endpoints for office 365 syncing

fb907b6

get web app url for oauth

00c97d4

update typings

808a3db

nethods for office 365 calendar

a3f8e64

update office 365 connect endpoint

bda0a26

update packages

093182a

add calendar type and if office 365 calendar

af0df73

add SelectedCalendarsRepository and TokensModule

6bea3a2

add functions for getting oauth credentials, getting default calendar…

263402a

…s and redirect url for office 365 calendar

update controllers

fd2bf7c

keithwillcode added core area: core, team members only platform Anything related to our platform plan labels May 16, 2024

graphite-app bot requested a review from a team May 16, 2024 11:22

dosubot bot added api area: API, enterprise API, access token, OAuth calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar ✨ feature New feature or request labels May 16, 2024

Merge branch 'main' into rajiv/cal-3544-outlookoffice365-integration-…

14a5cb7

…connect-atom

vercel bot deployed to Preview – ai May 16, 2024 11:26 View deployment

vercel bot deployed to Preview – api May 16, 2024 11:32 View deployment

vercel bot deployed to Preview – dev May 16, 2024 11:44 View deployment

e2e tests for office 365 calendar endpoints

5ec9b0e

vercel bot deployed to Preview – api May 16, 2024 13:34 View deployment

vercel bot deployed to Preview – dev May 16, 2024 13:40 View deployment

ThyMinimalDev reviewed May 31, 2024

View reviewed changes

Rajiv Sahal and others added 3 commits June 1, 2024 21:49

rename microsoft calendar type

4086465

fix typings

a23d24e

Merge branch 'main' into rajiv/cal-3544-outlookoffice365-integration-…

6b2534e

…connect-atom

vercel bot deployed to Preview – ai June 1, 2024 16:25 View deployment

vercel bot deployed to Preview – api June 1, 2024 16:34 View deployment

vercel bot deployed to Preview – dev June 1, 2024 16:43 View deployment

Rajiv Sahal added 2 commits June 1, 2024 23:22

add google and outlook calendar service to calendars module

1aed6ef

fixup

ade9865

vercel bot deployed to Preview – api June 1, 2024 18:00 View deployment

vercel bot deployed to Preview – dev June 1, 2024 18:06 View deployment

some more e2e tests including google calendar

7729243

vercel bot deployed to Preview – api June 2, 2024 21:47 View deployment

vercel bot deployed to Preview – dev June 2, 2024 21:53 View deployment

Merge branch 'main' into rajiv/cal-3544-outlookoffice365-integration-…

37f3f07

…connect-atom

vercel bot deployed to Preview – ai June 3, 2024 09:36 View deployment

vercel bot deployed to Preview – api June 3, 2024 09:40 View deployment

vercel bot deployed to Preview – dev June 3, 2024 09:46 View deployment

chore: small type change and apple calendar not implemented yet

cb7e821

ThyMinimalDev approved these changes Jun 3, 2024

View reviewed changes

vercel bot deployed to Preview – api June 3, 2024 10:21 View deployment

vercel bot deployed to Preview – dev June 3, 2024 10:26 View deployment

ThyMinimalDev requested a review from supalarry June 3, 2024 11:43

ThyMinimalDev approved these changes Jun 3, 2024

View reviewed changes

ThyMinimalDev added this pull request to the merge queue Jun 3, 2024

Merged via the queue into main with commit 9770aff Jun 3, 2024
22 of 24 checks passed

ThyMinimalDev deleted the rajiv/cal-3544-outlookoffice365-integration-connect-atom branch June 3, 2024 12:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: outlook 365 calendar endpoints #15077

feat: outlook 365 calendar endpoints #15077

Ryukemeister commented May 16, 2024 •

edited

linear bot commented May 16, 2024

github-actions bot commented May 16, 2024 •

edited

socket-security bot commented May 16, 2024 •

edited

vercel bot commented May 16, 2024 •

edited

graphite-app bot commented May 16, 2024

github-actions bot commented May 16, 2024 •

edited

deploysentinel bot commented May 16, 2024 •

edited

Test Case Results

Test Case Results

ThyMinimalDev May 31, 2024

ThyMinimalDev May 31, 2024

feat: outlook 365 calendar endpoints #15077

feat: outlook 365 calendar endpoints #15077

Conversation

Ryukemeister commented May 16, 2024 • edited

What does this PR do?

linear bot commented May 16, 2024

github-actions bot commented May 16, 2024 • edited

socket-security bot commented May 16, 2024 • edited

Next steps

vercel bot commented May 16, 2024 • edited

graphite-app bot commented May 16, 2024

Graphite Automations

github-actions bot commented May 16, 2024 • edited

📦 Next.js Bundle Analysis for @calcom/web

deploysentinel bot commented May 16, 2024 • edited

Current Playwright Test Results Summary

❌ Failures

Test Case Results

⚠️ Flakes

Test Case Results

ThyMinimalDev May 31, 2024

Choose a reason for hiding this comment

ThyMinimalDev May 31, 2024

Choose a reason for hiding this comment

Ryukemeister commented May 16, 2024 •

edited

github-actions bot commented May 16, 2024 •

edited

socket-security bot commented May 16, 2024 •

edited

vercel bot commented May 16, 2024 •

edited

github-actions bot commented May 16, 2024 •

edited

deploysentinel bot commented May 16, 2024 •

edited