Ensure that dateRanges start and end have same timezone #15043

hariombalhara · 2024-05-15T07:54:52Z

What does this PR do?

Fixes #XXXX (GitHub issue number)
Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Fixes the issue where the very first slot is not bookable https://www.loom.com/share/c2aa5e70d038432e951796325bc3fa32

The reason behind the issue was that range.start isn't in the correct timezone. It uses system timezone when infact we expect it to be in user's availability timezone for the event(I guess).

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected)
I have added a Docs issue here if this PR makes changes that would require a documentation change
I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

Are there environment variables that should be set?
What are the minimal test data to have?
What is expected (happy path) to have (input and output)?
Any other important info that could help to test that PR

Checklist

I haven't read the contributing guide
My code doesn't follow the style guidelines of this project
I haven't commented my code, particularly in hard-to-understand areas
I haven't checked if my changes generate no new warnings

vercel · 2024-05-15T07:55:00Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 15, 2024 8:53am

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		May 15, 2024 8:53am
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		May 15, 2024 8:53am

github-actions · 2024-05-15T07:55:04Z

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Ensure that dateRanges start and end have same timezone". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

hariombalhara · 2024-05-15T07:55:09Z

Ensure that dateRanges start and end have same timezone #15043 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hariombalhara and the rest of your teammates on Graphite

github-actions · 2024-05-15T08:06:00Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (`350 KB`)
`/settings/platform`	`261.21 KB`	489.84 KB	139.95% (🟢 -0.15%)
`/settings/platform/oauth-clients/[clientId]/edit`	`259.82 KB`	488.45 KB	139.56% (🟢 -0.15%)
`/settings/platform/oauth-clients/create`	`259.1 KB`	487.72 KB	139.35% (🟢 -0.15%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

deploysentinel · 2024-05-15T08:59:40Z

Current Playwright Test Results Summary

✅ 318 Passing - ❌ 1 Failing - ⚠️ 22 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/15/2024 09:04:07am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 9335c24

Started: 05/15/2024 08:59:11am UTC

❌ Failures

📄 apps/web/playwright/event-types.e2e.ts • 1 Failure

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved Retry 2 • Retry 1 • Initial Attempt Error: Test timeout of 60000ms exceeded. `Test timeout of 60000ms exceeded.`	3.39% (8) 8 / 236 runs failed over last 7 days	16.53% (39) 39 / 236 runs flaked over last 7 days

⚠️ Flakes

📄 apps/web/playwright/integrations-stripe.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Stripe integration Can book a paid booking Retry 1 • Initial Attempt	3.17% (7) 7 / 221 runs failed over last 7 days	13.57% (30) 30 / 221 runs flaked over last 7 days
Stripe integration When event is paid and confirmed Payment should confirm pending payment booking Retry 1 • Initial Attempt	2.76% (6) 6 / 217 runs failed over last 7 days	5.99% (13) 13 / 217 runs flaked over last 7 days

📄 apps/web/playwright/profile.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Update Profile Can update a users email (verification enabled) Retry 2 • Retry 1 • Initial Attempt	37.84% (98) 98 / 259 runs failed over last 7 days	33.59% (87) 87 / 259 runs flaked over last 7 days
Update Profile Can verify the newly added secondary email Retry 1 • Initial Attempt	2.30% (6) 6 / 261 runs failed over last 7 days	23.75% (62) 62 / 261 runs flaked over last 7 days

📄 apps/web/playwright/insights.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Insights should be able to go to insights as members Retry 1 • Initial Attempt	0% (0) 0 / 234 runs failed over last 7 days	3.42% (8) 8 / 234 runs flaked over last 7 days
Insights team select filter should have 2 teams and your account option only as member Retry 1 • Initial Attempt	0% (0) 0 / 234 runs failed over last 7 days	0.43% (1) 1 / 234 run flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes

Top 1 Common Error Messages

`null`	4 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace Retry 1 • Initial Attempt	0.43% (1) 1 / 231 run failed over last 7 days	57.58% (133) 133 / 231 runs flaked over last 7 days
Namespacing Inline Embed Add inline embed using a namespace without reload Retry 1 • Initial Attempt	0.43% (1) 1 / 231 run failed over last 7 days	56.71% (131) 131 / 231 runs flaked over last 7 days
Namespacing Different namespaces can have different init configs Retry 1 • Initial Attempt	0% (0) 0 / 229 runs failed over last 7 days	57.21% (131) 131 / 229 runs flaked over last 7 days
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace) Retry 1 • Initial Attempt	0% (0) 0 / 231 runs failed over last 7 days	60.17% (139) 139 / 231 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 9 Flakes

Top 1 Common Error Messages

`null`	9 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme Retry 1 • Initial Attempt	-1.29% (-3) -3 / 233 runs failed over last 7 days	59.23% (138) 138 / 233 runs flaked over last 7 days
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	-140.82% (-138) -138 / 98 runs failed over last 7 days	140.82% (138) 138 / 98 runs flaked over last 7 days
Popup Tests should open Routing Forms embed on click Retry 1 • Initial Attempt	-138.78% (-136) -136 / 98 runs failed over last 7 days	138.78% (136) 136 / 98 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API Retry 1 • Initial Attempt	-132.65% (-130) -130 / 98 runs failed over last 7 days	134.69% (132) 132 / 98 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API Retry 1 • Initial Attempt	-137.50% (-132) -132 / 96 runs failed over last 7 days	137.50% (132) 132 / 96 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API Retry 1 • Initial Attempt	-137.50% (-132) -132 / 96 runs failed over last 7 days	137.50% (132) 132 / 96 runs flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API Retry 1 • Initial Attempt	-137.50% (-132) -132 / 96 runs failed over last 7 days	137.50% (132) 132 / 96 runs flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it Retry 1 • Initial Attempt	-137.50% (-132) -132 / 96 runs failed over last 7 days	137.50% (132) 132 / 96 runs flaked over last 7 days
Popup Tests should open on clicking child element Retry 1 • Initial Attempt	-135.79% (-129) -129 / 95 runs failed over last 7 days	135.79% (129) 129 / 95 runs flaked over last 7 days

📄 apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard Retry 1 • Initial Attempt	5.06% (12) 12 / 237 runs failed over last 7 days	31.65% (75) 75 / 237 runs flaked over last 7 days

📄 apps/web/playwright/organization/booking.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Bookings Team Event Can create a booking for Round Robin EventType Retry 1 • Initial Attempt	5.83% (14) 14 / 240 runs failed over last 7 days	26.67% (64) 64 / 240 runs flaked over last 7 days

📄 apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
MEETING_ENDED, MEETING_STARTED should create/remove scheduledWebhookTriggers for existing bookings Retry 1 • Initial Attempt	5.94% (6) 6 / 101 runs failed over last 7 days	38.61% (39) 39 / 101 runs flaked over last 7 days

View Detailed Build Results

github-actions · 2024-05-30T00:17:50Z

This PR is being marked as stale due to inactivity.

keithwillcode added consumer core area: core, team members only labels May 15, 2024

vercel bot deployed to Preview – ai May 15, 2024 07:57 View deployment

vercel bot deployed to Preview – api May 15, 2024 08:01 View deployment

vercel bot deployed to Preview – dev May 15, 2024 08:06 View deployment

hariombalhara force-pushed the fix-buffer-calculations branch from 88cd6dc to 688bb1f Compare May 15, 2024 08:13

vercel bot deployed to Preview – ai May 15, 2024 08:16 View deployment

vercel bot deployed to Preview – api May 15, 2024 08:20 View deployment

vercel bot deployed to Preview – dev May 15, 2024 08:25 View deployment

Ensure that dateRanges start and end have same timezone

9335c24

hariombalhara force-pushed the fix-buffer-calculations branch from 688bb1f to 9335c24 Compare May 15, 2024 08:50

vercel bot deployed to Preview – ai May 15, 2024 08:53 View deployment

vercel bot deployed to Preview – api May 15, 2024 08:57 View deployment

vercel bot deployed to Preview – dev May 15, 2024 09:03 View deployment

keithwillcode added this to the v4.2 milestone May 15, 2024

github-actions bot added the Stale label May 30, 2024

hariombalhara removed the Stale label May 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure that dateRanges start and end have same timezone #15043

Ensure that dateRanges start and end have same timezone #15043

hariombalhara commented May 15, 2024 •

edited

vercel bot commented May 15, 2024 •

edited

github-actions bot commented May 15, 2024 •

edited

hariombalhara commented May 15, 2024

github-actions bot commented May 15, 2024 •

edited

deploysentinel bot commented May 15, 2024 •

edited

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

github-actions bot commented May 30, 2024

Ensure that dateRanges start and end have same timezone #15043

Are you sure you want to change the base?

Ensure that dateRanges start and end have same timezone #15043

Conversation

hariombalhara commented May 15, 2024 • edited

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

Checklist

vercel bot commented May 15, 2024 • edited

github-actions bot commented May 15, 2024 • edited

hariombalhara commented May 15, 2024

github-actions bot commented May 15, 2024 • edited

📦 Next.js Bundle Analysis for @calcom/web

Three Pages Changed Size

deploysentinel bot commented May 15, 2024 • edited

Current Playwright Test Results Summary

❌ Failures

Test Case Results

⚠️ Flakes

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

Test Case Results

github-actions bot commented May 30, 2024

hariombalhara commented May 15, 2024 •

edited

vercel bot commented May 15, 2024 •

edited

github-actions bot commented May 15, 2024 •

edited

github-actions bot commented May 15, 2024 •

edited

deploysentinel bot commented May 15, 2024 •

edited